-
-
Notifications
You must be signed in to change notification settings - Fork 917
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update tests #759
base: master
Are you sure you want to change the base?
Update tests #759
Conversation
I've verified that this works, and quite speedily, but I do have a couple outstanding concerns:
|
Some thoughts on this:
|
When I implemented this I was only thinking of running the tests via Actions, and totally forgot that someone would want to run them locally (whoops!). I chose Bun as an all-in-one tool for testing and as a learning exercise Addressing local testing: downloading v.Nu just to check one or a couple of icons might be a bit overkill, so I'm thinking of having local tests, fetching W3C like the original Also I'll look into v.Nu options later today! |
I don't think it's a big deal to download v.Nu (at ~32MB, it is larger than I expected, but not unreasonably so), and I'd rather use the same thing to test locally and with Actions, since my main motivation for local running is to debug problems spotted by Actions. In particular if validator.w3.org updates sooner/later than the npm repo, it could potentially cause some headaches. I do really like the idea of running v.Nu locally to make tests a lot faster, including through Actions. |
New tests:
Notes:
bun install
still only takes ~600 ms, compared to ~2 s ofnpm install
with old tests